Commit Graph
2139 Commits
Author SHA1 Message Date
Thomas Wolf df99f8c5a1 Merge pull request #1832 from huggingface/memory-leak-schedulers
replace LambdaLR scheduler wrappers by function
2019-11-14 22:10:31 +01:00
Thomas Wolf 0be9ae7b3e Merge pull request #1833 from huggingface/max-length-warning
Token indices sequence length is longer than the specified maximum sequence length for this model
2019-11-14 22:04:49 +01:00
Lysandre be7f2aacce [CI][DOC] Don't rebuild if folder exists - Correct directory. 2019-11-14 14:54:44 -05:00
Lysandre 8f8d69716a [CI][DOC] Don't rebuild if folder exists. 2019-11-14 14:48:21 -05:00
Rémi Louf 2276bf69b7 update the examples, docs and template 2019-11-14 20:38:02 +01:00
Lysandre d7929899da Specify checkpoint in saved file for run_lm_finetuning.py 2019-11-14 10:49:00 -05:00
Lysandre a67e747889 Reorganized max_len warning 2019-11-14 10:30:22 -05:00
Lysandre e18f786cd5 Quickstart example showcasing past 2019-11-14 10:06:00 -05:00
Rémi Louf 022525b003 replace LambdaLR scheduler wrappers by function
Custom schedulers are currently initiated by wrapping Pytorch's LambdaLR
class and passing a method of the wrapping class to the __init__
function of LambdaLR. This approach is not appropriate for several
reasons:

1. one does not need to define a class when it only defines a
__init__() method;
2. instantiating the parent class by passing a method of the child class
creates a cyclical reference which leads to memory leaks. See issues #1742 and #1134.

In this commit we replace the wrapper classes with functions that
instantiate `LambdaLR` with a custom learning rate function. We use a
closure to specify the parameter of the latter. We also do a bit of
renaming within the function to explicit the behaviour and removed
docstrings that were subsequently not necessary.
2019-11-14 15:39:08 +01:00
Julien Chaumond 155c782a2c [inputs_embeds] All TF models + tests 2019-11-12 11:29:21 -05:00
Julien Chaumond 2aef2f0bbc [common attributes] Fix previous commit for transfo-xl 2019-11-12 11:29:21 -05:00
Julien Chaumond 2f17464266 [common attributes] Slightly sharper test coverage 2019-11-12 11:29:21 -05:00
Julien Chaumond 9d2398fd99 Ooopsie 2019-11-12 11:29:21 -05:00
Julien Chaumond 70d97ddd60 [TF models] Common attributes as per #1721 2019-11-12 11:29:21 -05:00
Julien Chaumond 872403be1c This is not a @property after all 2019-11-12 11:29:21 -05:00
Julien Chaumond dd6b2e05e1 whitespace 2019-11-12 11:29:21 -05:00
Lysandre d409aca326 Clarify the use of past in GPT2 and CTRL 2019-11-12 10:59:37 -05:00
thomwolf 8aba81a0b6 fix #1789 2019-11-12 08:52:43 +01:00
Lysandre b5d330d118 Fix #1784 2019-11-11 10:15:14 -05:00
Adrian Bauer 7a9aae1044 Fix run_bertology.py
Make imports and args.overwrite_cache match run_glue.py
2019-11-08 16:28:40 -05:00
1c542df7e5 Add RoBERTa-based GPT-2 Output Detector from OpenAI
converted from https://github.com/openai/gpt-2-output-dataset/tree/master/detector

Co-Authored-By: Lysandre Debut <lysandre.debut@reseau.eseo.fr>
Co-Authored-By: Jong Wook Kim <jongwook@nyu.edu>
Co-Authored-By: Jeff Wu <wuthefwasthat@gmail.com>
2019-11-06 16:26:31 -05:00
Julien Chaumond 2f3a421018 Fix other PyTorch models 2019-11-06 14:03:47 -05:00
Julien Chaumond d5319793c4 Fix BERT 2019-11-06 14:03:47 -05:00
Julien Chaumond 27e015bd54 [tests] Flag to test on cuda 2019-11-06 14:03:47 -05:00
Julien Chaumond 13d9135fa5 [tests] get rid of warning
cf. https://docs.pytest.org/en/latest/example/simple.html
2019-11-06 14:03:47 -05:00
Julien Chaumond f88c104d8f [run_tf_glue] Add comment for context 2019-11-05 19:56:43 -05:00
Julien Chaumond 30968d70af misc doc 2019-11-05 19:06:12 -05:00
Dom Hudson de890ae67d Updating docblocks in optimizers.py 2019-11-05 17:31:29 -05:00
Lysandre d7d36181fd GPT-2 XL 2019-11-05 13:31:58 -05:00
Julien Chaumond 7daacf00df Merge pull request #1695 from huggingface/models_inputs_embeds
model forwards can take an inputs_embeds param
2019-11-05 09:55:28 -05:00
Clement a44f112fb9 add authors for models 2019-11-05 08:48:26 -05:00
Thomas Wolf e99071f105 Merge pull request #1734 from orena1/patch-1
add progress bar to convert_examples_to_features
2019-11-05 11:34:20 +01:00
Thomas Wolf ba973342e3 Merge pull request #1553 from WilliamTambellini/timeSquadInference
Add speed log to examples/run_squad.py
2019-11-05 11:13:12 +01:00
Thomas Wolf 237fad339c Merge pull request #1709 from oneraghavan/master
Fixing mode in evaluate during training
2019-11-05 10:55:33 +01:00
thomwolf f1e4db2aa8 Fix #1686 2019-11-05 09:38:00 +01:00
Oren Amsalem d7906165a3 add progress bar for convert_examples_to_features
It takes considerate amount of time (~10 min) to parse the examples to features, it is good to have a progress-bar to track this
2019-11-05 10:34:27 +02:00
Thomas Wolf d2e2577dd3 Merge pull request #1723 from huggingface/fix-1623
Fix #1623
2019-11-05 08:36:30 +01:00
Julien Chaumond 00337e9687 [inputs_embeds] All PyTorch models 2019-11-05 00:39:18 +00:00
Julien Chaumond 9eddf44b7a docstring + check 2019-11-04 17:19:15 +00:00
Julien Chaumond 8e11de0e86 model forwards can take an inputs_embeds param 2019-11-04 16:56:26 +00:00
LysandreandSantosh-Gupta 68f7064a3e Add model.train() line to ReadMe training example
Co-Authored-By: Santosh-Gupta <San.Gupta.ML@gmail.com>
2019-11-04 11:52:35 -05:00
Thomas Wolf c8f2712199 Merge pull request #1721 from huggingface/common_attributes
Add common getter and setter for input_embeddings & output_embeddings
2019-11-04 16:21:52 +01:00
thomwolf 89d6272898 Fix #1623 2019-11-04 16:21:12 +01:00
thomwolf b340a910ed fix tests - flagged as slow all the tests downloading from AWS 2019-11-04 16:03:36 +01:00
thomwolf f02805da6f fix tests 2019-11-04 15:42:23 +01:00
Thomas Wolf 1d4d070256 Merge pull request #1549 from hlums/master
Fix token order in xlnet preprocessing for SQuAD
2019-11-04 15:37:15 +01:00
thomwolf 1724cee8c4 switch from properties to methods 2019-11-04 15:34:10 +01:00
thomwolf 9b45d0f878 Add common properties input_embeddings and output_embeddings 2019-11-04 12:28:56 +01:00
Thomas Wolf 9a3b173cd3 Merge branch 'master' into master 2019-11-04 11:41:26 +01:00
thomwolf ad90868627 Update example readme 2019-11-04 11:27:22 +01:00