The full path to ssh.exe and mosh.exe was being stored in SSH profiles.
The path to mosh.exe includes FluentTerminal's version number causing
SSH profiles to break after an upgrade.
Instead, a token indicating SSH or Mosh is stored in the profile
instead. This is resolved just before the shell is started.
This change also meant that the infrastructure for the
"GetMoshSshExecutable" system tray request is no longer required, so
this has been removed.
* Minor improvements to remote SSH profiles. Username prefilled, and line ending defaults to LF.
* Implementing "Set Default" on SSH Profiles.
* Simplifying profile view models.
* Fixing null themes issue.
* Changing line ending of a sinfle file to CRLF.
* Changing file to LF, to avoid false differences.
* Converting a file to LF in order to avoid false differences.
* Fixining a bug with shortcuts.
* Added missing resource strings for new SSH bindings
Without these the settings page has no labels for these bindings.
* Rationalise default SSH keybindings
The logic is:
- Adhoc SSH tabs and windows are based around the Y key
- SSH profile tabs and windows are based around the U key (next to Y and
easier to reach than Z)
* Reorder command enum
Group commands together in a more logical order. In particular, this
makes command keybindings appear in a more logical order on the relevant
Settings page.
Note: this does not break existing keybinding configuration.
The keyboard shortcuts for local and SSH profiles will now result in the
new terminal being started in a window if "Open new terminals as" is set
to "Windows".
The diff is longer than strictly necessary because Visual Studio fixed
inconsistent line endings.
* Implementing SSH (changes from ap/ssh branch).
* Implemented opening links in the last active window.
* Using settings to determine where to open link (tab or window).
* Adding FluentTerminal.App_TemporaryKey.pfx back to repo, to solve bug with keys.
* App activation on mosh schema launching; mosh protocol parsing. (#35)
* SSH handling changed to improve links.
* Creating shortcuts from SSH dialog.
* Trivial Mosh checkbox label fix
It's "Mosh" not "MOSH".
* Obtain mosh key from ssh connection (#40)
* Prepopulate SSH username with Windows username (#50)
* Undoing Max's mosh authentication changes.
* Adding the new mosh wrapper.
* Request user name from tray process (#51)
* Mosh implemented, but still doesn't work (cannot find mosh.exe).
* Add New Remote Shell menu; Rename New Tab into New Local Shell (#52)
* Mosh works like charm.
* Mosh wrapper improved to print an error.
* Changing mosh wrapper to always exit with 0 (to ensure that the tab gets closed).
* Changing mosh wrapper again to return error codes.
* Slightly optimizing getting the username.
* Saving links improved.
* Fixed an issue in mosh wrapper, related to mosh to hostname.
* mosh-client.exe updated with 32 bit version for x86 platform (#59)
* Set line endings for remote shell connection;
Left focus on SSH info dialog if input validation error occured;
Update DataContext object on each key entered into target host text box control.
* Simplifying SSH dialog.
* Fixing some leftovers after merging.
* Fixing some after-merge issues.
* Avoiding some unintentional upstream changes.
* Fix review findings
Make the shell process's exit code available to the main app so that
actions can be taken depending on whether the shell command was
successful or not.
Later work will build on this so that failed commands will result in
tabs being left open when the shell command fails. This will help when
troubleshooting incorrectly configured profiles, SSH connection issues
etc.
Exit codes are passed up for both WinPty and ConPty based terminals.
* Fix finding SSH when executing as 32-bit process on a 64-bit operational system
* Display a suitable error message when no OpenSSH client installed
and the user tries to open an SSH connection
* Creating a control for the overlay
* using Interactivity
* trying to bind by reference
* fix bindings
* remove unused packages
* Move getter/setter to show method
* Convert to AutoProperty
* Make text copied notification configurable
* cache settings, removed unused file
* Appveyor builds (#6)
* SSH implemented.
* Implementing SSH by using the existing app infrastructure.
* Refactored to new command instead of a profile
* Update .gitignore
* Encapsulate xterm.js implementation in XtermTerminalView
* fix TerminalTheme Equals()
* Fix new output indicator
* Ut8 and some fixes
* fix test
* fixed infinite loop on shell exit
* Update settings window layout with consistent margins
Updated the layout of the different views of the settings window so that
there is always margin at the bottom. In some cases this was achieved
using <StackPanels> for clarity and extensibility, grouping e.g. a title
and some radio options together with one unified margin.
Also made some small consistency changes to the .xaml files.
* Add width to Themes text input
* Normalize margins in settings
* Add default display values in Terminal settings
... for Arguments and Working Directory
* Generalize TemplateSelector for empty strings
* Add default display value for profile keybindings
* Update margins and fontsize in theme preview
* Update 'loading...' message in About
... to "Checking for updates..." and a spinner as suggested by
@skipmeister123
* No popup when cancelling profile edit no changes
* Delete profile when new and cancelled
* Open new and cloned themes in edit mode
... and make it so canceling deletes the theme.
* No popup when cancelling theme edit no changes
* Add resources for margin definitions
* Check for null Author in TerminalTheme
* Add resource for header margin definition
* Moved createdBy text to code behind
* On paste, the TerminalViewModel uses the ShellProfile to translate line endings.
Default line ending translation style is set to not modify the pasted contents, Next up, adding the radio button to shell profile.
* Added UI elements for choosing line ending style.
Using a converter to map between an enum and radio buttons, and another converter to map from enum to text based on the description of the enum value.
* Added "Paste without newlines" command.
* Adding missing converters to project file.
* A few fixes after cherry-picks.
* Adding missing Command property to PasteWithoutNewlines keybinding.
* Cleaned up some unnecessary property settings.
* fix#114 scrolling issue on presicion touchpads (#171)
* fix#114 scrolling issue on presicion touchpads, bounce scroll & pinch zoom
* rephrased comment
* removed css that enforced autohiding
* simplified js code handling scrollbar size
* Press enter to close an Input dialog (#177)
... As if the primary button is pressed.
* Renew certificate
* Update README.md
* Add option to use bold text in terminals (#183)
* Add option to use bold text in terminals
... as per #182
* Add BoldText to setting defaults
* Remove AppVeyor files
* Update README.md
* Add keybinding to change the (current) tab title (#193)
* Add keybinding for change the (current) tab title
Default binding is Ctrl+Shift+N
* Update change tab title default keybind to Ctrl+Shift+R
* Experimental ConPTY support (#199)
* First steps of ConPty support
* Added resize functionality
* fix cwd, args, hide console window
* Handle shell process exited
* Make ConPTY optional
* Fix automerge errors
* Accepted many XAML formatting changes, and changed command handling to switch.
* Fixed spaxcng on the settings page.
* adapted radio button binding to be in line with the rest of the application
* Added new command wrapper, abstracts static and dynamic commands
- All uses of the `Command` are replaced with either `AppCommand`, for a command that is static to the scope of the application, or a reference to an ICommand (specifically, an `EnumCommand<AppCommand>()` instance), which provides the abstract wrapper.
- Functionality seems intact.
- Next step is to have the MainViewModel add the per-shell commands via SettingsService.CreateShellKeyboardShortcuts(), and have the SettingsService.ParseCommandString() function parse the command strings passed around properly.
- Finally, add the keyboard chord input to each shell's settings page.
* First kick at adding a new terminal keyboard command.
- It isn't presented anywhere, but references to keybindings should be using the ICommand key as their identifier for recognizing anything, and when xterm passes back a keyboard command event, the SettingsService is asked to convert the string into an ICommand.
* Renaming ICommand to Command.
It's not longer an interface, so this makes more sense.
* Renaming back to Command, and new class is AbstractCommand.
Going to simplify the PR diff considerably.
* Shortcuts for default shells work. Need to get the shell profile edit UI elements working.
* Added keyboard shortcut UI elements to shell profile pages.
* New and deleted shell profiles propagate to all terminal views.
* A bit of cleanup.
* Camel-casing command text to fix Ctrl+C and copy behaviour.
* Fixed failing test.
The new on disk store uses a .ToString(), not the Enum description, since the command isn't an Enum, it's a class now in general, and those semantics make more sense.
* Adding default value for null keybindings in shell profiles.
* Merge branch 'shell_commands' of https://github.com/Riebart/FluentTerminal into pr/85
Improved default value for keybinding property
* Renamed KeyBinding collection to KeyBindings
* Use strings as Command parameter of KeyBinding
* Added missing Commands to keyBindings of default shellProfiles
* fix build and unit tests after merge with master
* improve UI
* Split OnShellProfileCollectionChanged event
* Add "Show in system tray" option to the SettingsView
* Implement "Show in system tray" requiring restart
* Add warning to restart program when toggling tray
* Update warning text for toggling tray option
* add padding setting
* `=` instead of `:`
Co-Authored-By: fauzie811 <fauzie811@yahoo.com>
* call setPadding in createTerminal function
* Add "px" suffix to padding slider tooltip
Based on this tutorial:
https://www.codeproject.com/Tips/715438/Slider-Thumb-Tooltip
* term.fit() after setPadding()
* move back term.fit() below term.open()
* Changed max value, added throttling, moved converter
Max Risuhin