Themes can now be cloned

FluentTerminal.App.ViewModels/Settings/ThemesPageViewModel.cs

@@ -31,6 +31,7 @@ namespace FluentTerminal.App.ViewModels.Settings
 
             CreateThemeCommand = new RelayCommand(CreateTheme);
             ImportThemeCommand = new RelayCommand(ImportTheme);
+            CloneCommand = new RelayCommand<ThemeViewModel>(CloneTheme);
 
             _settingsService.TerminalOptionsChanged += OnTerminalOptionsChanged;
 
@@ -55,6 +56,7 @@ namespace FluentTerminal.App.ViewModels.Settings
 
         public RelayCommand CreateThemeCommand { get; }
         public RelayCommand ImportThemeCommand { get; }
+        public RelayCommand<ThemeViewModel> CloneCommand { get; set; }
 
         public double BackgroundOpacity
         {
@@ -81,6 +83,18 @@ namespace FluentTerminal.App.ViewModels.Settings
 
         public ObservableCollection<ThemeViewModel> Themes { get; } = new ObservableCollection<ThemeViewModel>();
 
+        private void CloneTheme(ThemeViewModel theme)
+        {
+            var cloned = new TerminalTheme(theme.Model)
+            {
+                Id = Guid.NewGuid(),
+                PreInstalled = false,
+                Name = $"Copy of {theme.Name}"
+            };
+
+            AddTheme(cloned);
+        }
+
         private void CreateTheme()
         {
             var defaultTheme = _settingsService.GetTheme(_defaultValueProvider.GetDefaultThemeId());
@@ -92,13 +106,7 @@ namespace FluentTerminal.App.ViewModels.Settings
                 Colors = new TerminalColors(defaultTheme.Colors)
             };
 
-            _settingsService.SaveTheme(theme, true);
-
-            var viewModel = new ThemeViewModel(theme, _settingsService, _dialogService, _fileSystemService);
-            viewModel.Activated += OnThemeActivated;
-            viewModel.Deleted += OnThemeDeleted;
-            Themes.Add(viewModel);
-            SelectedTheme = viewModel;
+            AddTheme(theme);
         }
 
         private async void ImportTheme()
@@ -118,13 +126,7 @@ namespace FluentTerminal.App.ViewModels.Settings
                 {
                     var theme = await parser.Parse(file.Name, file.Content).ConfigureAwait(true);
 
-                    _settingsService.SaveTheme(theme, true);
-
-                    var viewModel = new ThemeViewModel(theme, _settingsService, _dialogService, _fileSystemService);
-                    viewModel.Activated += OnThemeActivated;
-                    viewModel.Deleted += OnThemeDeleted;
-                    Themes.Add(viewModel);
-                    SelectedTheme = viewModel;
+                    AddTheme(theme);
                 }
                 catch (Exception exception)
                 {
@@ -133,6 +135,17 @@ namespace FluentTerminal.App.ViewModels.Settings
             }
         }
 
+        private void AddTheme(TerminalTheme theme)
+        {
+            _settingsService.SaveTheme(theme, true);
+
+            var viewModel = new ThemeViewModel(theme, _settingsService, _dialogService, _fileSystemService);
+            viewModel.Activated += OnThemeActivated;
+            viewModel.Deleted += OnThemeDeleted;
+            Themes.Add(viewModel);
+            SelectedTheme = viewModel;
+        }
+
         private void OnThemeActivated(object sender, EventArgs e)
         {
             if (sender is ThemeViewModel activatedTheme)

FluentTerminal.App.ViewModels/ThemeViewModel.cs

@@ -40,7 +40,6 @@ namespace FluentTerminal.App.ViewModels
         private string _name;
         private string _red;
         private string _selection;
-        private readonly TerminalTheme _theme;
         private string _white;
         private string _yellow;
         private readonly IFileSystemService _fileSystemService;
@@ -49,38 +48,38 @@ namespace FluentTerminal.App.ViewModels
 
         public ThemeViewModel(TerminalTheme theme, ISettingsService settingsService, IDialogService dialogService, IFileSystemService fileSystemService)
         {
-            _theme = theme;
+            Model = theme;
             _settingsService = settingsService;
             _dialogService = dialogService;
             _fileSystemService = fileSystemService;
 
-            Name = _theme.Name;
-            Author = _theme.Author;
-            Id = _theme.Id;
+            Name = Model.Name;
+            Author = Model.Author;
+            Id = Model.Id;
 
-            Black = _theme.Colors.Black;
-            Red = _theme.Colors.Red;
-            Green = _theme.Colors.Green;
-            Yellow = _theme.Colors.Yellow;
-            Blue = _theme.Colors.Blue;
-            Magenta = _theme.Colors.Magenta;
-            Cyan = _theme.Colors.Cyan;
-            White = _theme.Colors.White;
+            Black = Model.Colors.Black;
+            Red = Model.Colors.Red;
+            Green = Model.Colors.Green;
+            Yellow = Model.Colors.Yellow;
+            Blue = Model.Colors.Blue;
+            Magenta = Model.Colors.Magenta;
+            Cyan = Model.Colors.Cyan;
+            White = Model.Colors.White;
 
-            BrightBlack = _theme.Colors.BrightBlack;
-            BrightRed = _theme.Colors.BrightRed;
-            BrightGreen = _theme.Colors.BrightGreen;
-            BrightYellow = _theme.Colors.BrightYellow;
-            BrightBlue = _theme.Colors.BrightBlue;
-            BrightMagenta = _theme.Colors.BrightMagenta;
-            BrightCyan = _theme.Colors.BrightCyan;
-            BrightWhite = _theme.Colors.BrightWhite;
+            BrightBlack = Model.Colors.BrightBlack;
+            BrightRed = Model.Colors.BrightRed;
+            BrightGreen = Model.Colors.BrightGreen;
+            BrightYellow = Model.Colors.BrightYellow;
+            BrightBlue = Model.Colors.BrightBlue;
+            BrightMagenta = Model.Colors.BrightMagenta;
+            BrightCyan = Model.Colors.BrightCyan;
+            BrightWhite = Model.Colors.BrightWhite;
 
-            Background = _theme.Colors.Background;
-            Foreground = _theme.Colors.Foreground;
-            Cursor = _theme.Colors.Cursor;
-            CursorAccent = _theme.Colors.CursorAccent;
-            Selection = _theme.Colors.Selection;
+            Background = Model.Colors.Background;
+            Foreground = Model.Colors.Foreground;
+            Cursor = Model.Colors.Cursor;
+            CursorAccent = Model.Colors.CursorAccent;
+            Selection = Model.Colors.Selection;
 
             SetActiveCommand = new RelayCommand(SetActive);
             DeleteCommand = new RelayCommand(async () => await Delete().ConfigureAwait(false), NotPreInstalled);
@@ -94,6 +93,8 @@ namespace FluentTerminal.App.ViewModels
 
         public event EventHandler Deleted;
 
+        public TerminalTheme Model { get; }
+
         public string Author
         {
             get => _author;
@@ -268,34 +269,34 @@ namespace FluentTerminal.App.ViewModels
 
         public void SaveChanges()
         {
-            _theme.Name = Name;
-            _theme.Author = Author;
+            Model.Name = Name;
+            Model.Author = Author;
 
-            _theme.Colors.Black = Black;
-            _theme.Colors.Red = Red;
-            _theme.Colors.Green = Green;
-            _theme.Colors.Yellow = Yellow;
-            _theme.Colors.Blue = Blue;
-            _theme.Colors.Magenta = Magenta;
-            _theme.Colors.Cyan = Cyan;
-            _theme.Colors.White = White;
+            Model.Colors.Black = Black;
+            Model.Colors.Red = Red;
+            Model.Colors.Green = Green;
+            Model.Colors.Yellow = Yellow;
+            Model.Colors.Blue = Blue;
+            Model.Colors.Magenta = Magenta;
+            Model.Colors.Cyan = Cyan;
+            Model.Colors.White = White;
 
-            _theme.Colors.BrightBlack = BrightBlack;
-            _theme.Colors.BrightRed = BrightRed;
-            _theme.Colors.BrightGreen = BrightGreen;
-            _theme.Colors.BrightYellow = BrightYellow;
-            _theme.Colors.BrightBlue = BrightBlue;
-            _theme.Colors.BrightMagenta = BrightMagenta;
-            _theme.Colors.BrightCyan = BrightCyan;
-            _theme.Colors.BrightWhite = BrightWhite;
+            Model.Colors.BrightBlack = BrightBlack;
+            Model.Colors.BrightRed = BrightRed;
+            Model.Colors.BrightGreen = BrightGreen;
+            Model.Colors.BrightYellow = BrightYellow;
+            Model.Colors.BrightBlue = BrightBlue;
+            Model.Colors.BrightMagenta = BrightMagenta;
+            Model.Colors.BrightCyan = BrightCyan;
+            Model.Colors.BrightWhite = BrightWhite;
 
-            _theme.Colors.Background = Background;
-            _theme.Colors.Foreground = Foreground;
-            _theme.Colors.Cursor = Cursor;
-            _theme.Colors.CursorAccent = CursorAccent;
-            _theme.Colors.Selection = Selection;
+            Model.Colors.Background = Background;
+            Model.Colors.Foreground = Foreground;
+            Model.Colors.Cursor = Cursor;
+            Model.Colors.CursorAccent = CursorAccent;
+            Model.Colors.Selection = Selection;
 
-            _settingsService.SaveTheme(_theme);
+            _settingsService.SaveTheme(Model);
 
             InEditMode = false;
         }
@@ -339,7 +340,7 @@ namespace FluentTerminal.App.ViewModels
 
         private bool NotPreInstalled()
         {
-            return !_theme.PreInstalled;
+            return !Model.PreInstalled;
         }
 
         private async Task Delete()
@@ -354,7 +355,7 @@ namespace FluentTerminal.App.ViewModels
 
         private void Edit()
         {
-            _fallBackColors = new TerminalColors(_theme.Colors);
+            _fallBackColors = new TerminalColors(Model.Colors);
             _fallBackName = Name;
             _fallBackAuthor = Author;
             InEditMode = true;
@@ -367,7 +368,7 @@ namespace FluentTerminal.App.ViewModels
 
         private Task Export()
         {
-            var content = JsonConvert.SerializeObject(_theme, Formatting.Indented, new JsonSerializerSettings { ContractResolver = new TerminalThemeContractResolver() });
+            var content = JsonConvert.SerializeObject(Model, Formatting.Indented, new JsonSerializerSettings { ContractResolver = new TerminalThemeContractResolver() });
             return _fileSystemService.SaveTextFile(Name, "Fluent Terminal Theme", ".flutecolors", content);
         }
     }

FluentTerminal.App/Views/SettingsPages/ThemeSettings.xaml

@@ -63,6 +63,12 @@
                         <FontIcon FontFamily="Segoe MDL2 Assets" Glyph="&#xEE71;" />
                     </AppBarButton.Icon>
                 </AppBarButton>
+                <AppBarButton
+                    Name="CloneButton"
+                    Command="{x:Bind ViewModel.CloneCommand, Mode=OneWay}"
+                    CommandParameter="{x:Bind ViewModel.SelectedTheme, Mode=OneWay}"
+                    Icon="Copy"
+                    Label="Clone" />
                 <AppBarButton
                     Name="EditButton"
                     Command="{x:Bind ViewModel.SelectedTheme.EditCommand, Mode=OneWay}"

FluentTerminal.App/Views/SettingsPages/ThemeSettings.xaml.cs

@@ -41,6 +41,7 @@ namespace FluentTerminal.App.Views.SettingsPages
             SaveButton.RequestedTheme = theme;
             CancelButton.RequestedTheme = theme;
             ExportButton.RequestedTheme = theme;
+            CloneButton.RequestedTheme = theme;
 
             ContrastHelper.SetTitleBarButtonsForTheme(theme);
         }

FluentTerminal.Models/TerminalTheme.cs

@@ -4,6 +4,19 @@ namespace FluentTerminal.Models
 {
     public class TerminalTheme
     {
+        public TerminalTheme()
+        {
+        }
+
+        public TerminalTheme(TerminalTheme other)
+        {
+            Id = other.Id;
+            Name = other.Name;
+            Author = other.Author;
+            PreInstalled = other.PreInstalled;
+            Colors = new TerminalColors(other.Colors);
+        }
+
         public Guid Id { get; set; }
         public string Name { get; set; }
         public string Author { get; set; }