Commit Graph
114 Commits
Author SHA1 Message Date
thomwolf 9ce37af99b oups 2019-06-18 11:47:54 +02:00
thomwolf a40955f071 no need to duplicate models anymore 2019-06-18 11:46:14 +02:00
Thomas Wolf 277c77f1c5 Merge pull request #630 from tguens/master
Update run_squad.py
2019-06-14 16:56:26 +02:00
tguens 9e7bc51b95 Update run_squad.py
Indentation change so that the output "nbest_predictions.json" is not empty.
2019-05-22 17:27:59 +08:00
samuelbroscheit 94247ad6cb Make num_train_optimization_steps int 2019-05-13 12:38:22 +02:00
samuel.broscheit 49a77ac16f Clean up a little bit 2019-05-12 00:31:10 +02:00
samuel.broscheit 3bf3f9596f Fixing the issues reported in https://github.com/huggingface/pytorch-pretrained-BERT/issues/556
Reason for issue was that optimzation steps where computed from example size, which is different from actual size of dataloader when an example is chunked into multiple instances.

Solution in this pull request is to compute num_optimization_steps directly from len(data_loader).
2019-05-12 00:13:45 +02:00
burcturkoglu 00c7fd2b79 Division to num_train_optimizer of global_step in lr_this_step is removed. 2019-05-09 10:57:03 +03:00
burcturkoglu fa37b4da77 Merge branch 'master' of https://github.com/huggingface/pytorch-pretrained-BERT 2019-05-09 10:55:24 +03:00
burcturkoglu 5289b4b9e0 Division to num_train_optimizer of global_step in lr_this_step is removed. 2019-05-09 10:51:38 +03:00
MottoX 74dbba64bc Prepare optimizer only when args.do_train is True 2019-05-02 19:09:29 +08:00
thomwolf d94c6b0144 fix training schedules in examples to match new API 2019-04-23 11:17:06 +02:00
thomwolf 3571187ef6 fix saving models in distributed setting examples 2019-04-15 16:43:56 +02:00
thomwolf 2499b0a5fc add ptvsd to run_squad 2019-04-15 15:33:04 +02:00
thomwolf 7816f7921f clean up distributed training logging in run_squad example 2019-04-15 15:27:10 +02:00
thomwolf 1135f2384a clean up logger in examples for distributed case 2019-04-15 15:22:40 +02:00
thomwolf 60ea6c59d2 added best practices for serialization in README and examples 2019-04-15 15:00:33 +02:00
thomwolf 179a2c2ff6 update example to work with new serialization semantic 2019-04-15 14:33:23 +02:00
thomwolf 846b1fd6f8 Fix #419 2019-04-03 10:50:38 +02:00
Yongbo Wang d1e4fa98a9 typo in annotation
modify `heruistic` to `heuristic` in line 660, `charcter` to `character` in line 661.
2019-03-14 17:32:15 +08:00
Yongbo Wang 3d6452163d typo
modify `mull` to `null` in line 474 annotation.
2019-03-14 17:03:38 +08:00
thomwolf a98dfe4ced fixing #377 (empty nbest_predictions.json) 2019-03-14 09:57:06 +01:00
thomwolf 994d86609b fixing PYTORCH_PRETRAINED_BERT_CACHE use in examples 2019-03-06 10:21:24 +01:00
thomwolf 5c85fc3977 fix typo - logger info 2019-03-06 10:05:21 +01:00
wlhgtc 8efaf8f176 fix 'best_non_null_entry' is None error 2019-02-15 15:57:25 +08:00
thomwolf d38caba169 typo in run_squad 2019-02-11 14:10:27 +01:00
thomwolf af62cc5f20 fix run_squad example 2019-02-11 14:06:32 +01:00
thomwolf eebc8abbe2 clarify and unify model saving logic in examples 2019-02-11 14:04:19 +01:00
Thomas Wolf 848aae49e1 Merge branch 'master' into python_2 2019-02-06 00:13:20 +01:00
thomwolf 448937c00d python 2 compatibility 2019-02-06 00:07:46 +01:00
thomwolf d609ba24cb resolving merge conflicts 2019-02-05 16:14:25 +01:00
Thomas Wolf 64ce900974 Merge pull request #248 from JoeDumoulin/squad1.1-fix
fix prediction on run-squad.py example
2019-02-05 16:00:51 +01:00
Thomas Wolf e9e77cd3c4 Merge pull request #218 from matej-svejda/master
Fix learning rate problems in run_classifier.py
2019-02-05 15:40:44 +01:00
thomwolf 1579c53635 more explicit notation: num_train_step => num_train_optimization_steps 2019-02-05 15:36:33 +01:00
joe dumoulin aa90e0c36a fix prediction on run-squad.py example 2019-02-01 10:15:44 -08:00
Surya Kasturi 9bf528877e Update run_squad.py 2019-01-30 15:09:31 -05:00
Matej Svejda 5169069997 make examples consistent, revert error in num_train_steps calculation 2019-01-30 11:47:25 +01:00
Matej Svejda 9c6a48c8c3 fix learning rate/fp16 and warmup problem for all examples 2019-01-27 14:07:24 +01:00
Sang-Kil Park 64326dccfb Fix it to run properly even if without --do_train param.
It was modified similar to `run_classifier.py`, and Fixed to run properly even if without `--do_train` param.
2019-01-10 21:51:39 +09:00
thomwolf 2e4db64cab add do_lower_case tokenizer loading optino in run_squad and ine_tuning examples 2019-01-07 13:06:42 +01:00
thomwolf c9fd350567 remove default when action is store_true in arguments 2019-01-07 13:01:54 +01:00
Thomas Wolf d3d56f9a0b Merge pull request #166 from likejazz/patch-1
Fix error when `bert_model` param is path or url.
2019-01-07 12:40:55 +01:00
Sang-Kil Park ca4e7aaa72 Fix error when bert_model param is path or url.
Error occurs when `bert_model` param is path or url. Therefore, if it is path, specify the last path to prevent error.
2019-01-05 11:42:54 +09:00
Grégory Châtel 186f75342e Adding new pretrained model to the help of the bert_model argument. 2019-01-02 14:00:59 +01:00
thomwolf ae88eb88a4 set encoding to 'utf-8' in calls to open 2018-12-14 13:48:58 +01:00
thomwolf e1eab59aac no fp16 on evaluation 2018-12-13 14:54:02 +01:00
thomwolf 087798b7fa fix reloading model for evaluation in examples 2018-12-13 14:48:12 +01:00
thomwolf 0cf88ff084 make examples work without apex 2018-12-13 13:28:00 +01:00
thomwolf d3fcec1a3e add saving and loading model in examples 2018-12-13 12:50:44 +01:00
thomwolf b3caec5a56 adding save checkpoint and loading in examples 2018-12-13 12:48:13 +01:00