The crash occured because the popup is treated like the mainwindow and the main window grabs keypresses. Because of this a paste command can be executed on the main window when attempting to paste into the search box (when ctrl-c is used as a paste binding).
Adding an empty binding for copy and paste resolves this. Additionally it was required to prevent the terminal view from handling paste requests to prevent pasting to searchbox and terminal at the same time.
* Reviewed async pattern in App.xaml.cs.
* Reviewed async pattern throughout FluentTerminal.App project.
* Async patterns in TrayProcessCommunicationService reviewed.
* Minor changes.
* Replaced ContinueWith with async/await in TrayProcessCommunicationService.
* Minor change.
* Dispatcher reviewed and improved.
* Minor refactoring.
* XtermTerminalView initialization simplified.
* Additionally simplifying XtermTerminalView initialization.
* Replacing SemaphoreSlim with lighter TaskCompletionSource.
* Some async/await simplification.
* Resize locking mechanism in XtermTerminalView simplified.
* Resize handling improved.
* Trivial change in a code comment.
* After merge fixes, and some minor changes.
* DelayedAction fixed and some UI bug fixed.
* Removing TerminalViewModel.CustomTitleChanged event because it's covered by PropertyChanged anyway.
* Dispatcher reviewed and improved.
* Minor refactoring.
* XtermTerminalView initialization simplified.
* Additionally simplifying XtermTerminalView initialization.
* Replacing SemaphoreSlim with lighter TaskCompletionSource.
* Some async/await simplification.
* Resize locking mechanism in XtermTerminalView simplified.
* Resize handling improved.
* Trivial change in a code comment.
* After merge fixes, and some minor changes.
* Added icon to "Recent >" menu item.
* Refactored app menu implementation, and implemented keyboard accelerators. Still doesn't work though.
* Few things fixed, but still doesn't work.
* Clicking menu items works.
* Fixing an issue with resources.
* New menu binding implemented. Still doesn't work though.
* Menu displayed properly, except for "Settings".
* Menu works, but it doesn't refresh.
* Works. But needs to be polished.
* All known issues with the new app menu solved.
* Significantly simplifying app menu binding.
* Removing some obsolete classes.
* Menu binding mechanism additionally optimized for performances.
* Removing unused translations.
* Further refactoring app menu binding, in order to make it more general.
* Renaming menu items in order to make them usable for both new tab and new window commands.
* Changing menu item keyboard accelerators based on new tab / window settings.
* Menu item keyboard accelerators are dynamically changing with chainging terminals in new tabs/windows option.
* New tab / window settings honored for top level menu items.
* New window mechanism simplified. Terminal-launching code refactored to be more readable. A bug with "SSH Info" fixed.
* Merging the latest changed.
* Fixing some after-merge issues.
* Minor refactoring.
* Minor refactoring.
* Default profile menu item now contains the profile name. Still doesn't update though.
* Default profile name in the menu item now updates.
* Updating resources from POEditor.
* New tab/window cascading menues implemented.
* Reverting translations back to the correct (the latest) version.
* Undoing translation changes from the last commit. I've made these by mistake.
* Configurable tab/window cascading menu.
* "Application menu type" settings value added.
* Minor spelling fix.
* Fixing some after-merge issues.
* Added icon to "Recent >" menu item.
* Refactored app menu implementation, and implemented keyboard accelerators. Still doesn't work though.
* Few things fixed, but still doesn't work.
* Clicking menu items works.
* Fixing an issue with resources.
* New menu binding implemented. Still doesn't work though.
* Menu displayed properly, except for "Settings".
* Menu works, but it doesn't refresh.
* Works. But needs to be polished.
* All known issues with the new app menu solved.
* Significantly simplifying app menu binding.
* Removing some obsolete classes.
* Menu binding mechanism additionally optimized for performances.
* Removing unused translations.
* Further refactoring app menu binding, in order to make it more general.
* Renaming menu items in order to make them usable for both new tab and new window commands.
* Changing menu item keyboard accelerators based on new tab / window settings.
* Menu item keyboard accelerators are dynamically changing with chainging terminals in new tabs/windows option.
* New tab / window settings honored for top level menu items.
* New window mechanism simplified. Terminal-launching code refactored to be more readable. A bug with "SSH Info" fixed.
* Merging the latest changed.
* Fixing some after-merge issues.
* Minor refactoring.
* Minor refactoring.
* Default profile menu item now contains the profile name. Still doesn't update though.
* Default profile name in the menu item now updates.
* Reverting translations back to the correct (the latest) version.
* Undoing translation changes from the last commit. I've made these by mistake.
* Added icon to "Recent >" menu item.
* Refactored app menu implementation, and implemented keyboard accelerators. Still doesn't work though.
* Few things fixed, but still doesn't work.
* Clicking menu items works.
* Fixing an issue with resources.
* New menu binding implemented. Still doesn't work though.
* Menu displayed properly, except for "Settings".
* Menu works, but it doesn't refresh.
* Works. But needs to be polished.
* All known issues with the new app menu solved.
* Significantly simplifying app menu binding.
* Removing some obsolete classes.
* Menu binding mechanism additionally optimized for performances.
* Removing unused translations.
* Further refactoring app menu binding, in order to make it more general.
* New window mechanism simplified. Terminal-launching code refactored to be more readable. A bug with "SSH Info" fixed.
* Merging the latest changed.
* Refactoring CommandHistoryService to prepare "Recent" menu item feature.
* "Recent" menu implemented, but still not bound to commands.
* "Recent" menu implemented.
* - Force GC.Collect() on closing of terminal;
- Prepare MainPage, MainViewModel, TabBar, TerminalBridge for disposal.
* Request _dispatcherJobs Task cancellation ASAP on terminal closing.
* Separating "SSH Info" and "Quick Launch", and updating translations.
* Adding "Quick Launch" to menu.
* Auto-complete, initial version.
* Builds, but not finished.
* Improved, but there are still some bugs...
* Minor changes.
* Refactroing request/response identifiers.
* Improving command history.
* Minor refactoring.
* Deleting history by using "Del" key.
* Handling mosh special case in quick commands.
* SSH command handled as any other command in the path.
* New resource strings.
* Fixing quick command links.
* Fixing after-merging bugs.
* Improving filtering.
* Finishing filtering.
* Changing placeholder text.
* Minor refactoring.
* Updating resources.
* Renaming NewRemoteTab back to NewSshTab.
* Simplifying view models, step 1: Extracting common terminal configuration into TerminalInfoViewModel.cs.
* Simplifying a bit.
* SSH view models simplfication.
* Refactoring duplicated code.
* Refactoring duplicated code.
* Renaming a resource file.
* Cleanup.
* Fixing an issue with TemplateSelectors.
* QuickSshDialog created.
* Minor fix.
* Wiring up QuickSshDialog.
* Minor fix.
* Fixed an issue with shared resources.
* Single-text-box dialog works.
* Improving "Quick SSH" look.
* Improving data validation workflow to avoid double validations.
* Refactoring view models and templates to avoid duplicated code.
* Minor fix.
* Fixing a bug with mosh.
* Cleanup.
* Cleanup.
* Moving profile view models in a separate folder (namespace).
* Few comment lines (short description) added to profile view models.
* Removing IDisposable from view-models because event-caused memory leaks will be solved differently.
* Implemented quick-ssh shortcuts.
* Fixing quick SSH command validation.
* Minor change.
* Minor change.
* Combining "SSH Info" and "Quick SSH" into a single dialog.
* Quick SSH profiles.
* Fixing a minor bug with custom links.
* Fixing remote profiles look and feel.
* Minor improvements.
* Fixing a minor bug.
* Minor changes based on Felix' comments.
* Saving executed commands history implemented.
The keyboard shortcuts for local and SSH profiles will now result in the
new terminal being started in a window if "Open new terminals as" is set
to "Windows".
The diff is longer than strictly necessary because Visual Studio fixed
inconsistent line endings.
Felix Seidl